This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Restore macOS map SDK; clean up iOS, macOS changelogs #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restored macOS make targets, including the genstrings target shared between iOS and macOS. Updated macOS build settings to align with current CMake build system.
Fixed make warnings about duplicate commands getting overridden.
iOS and macOS once again share most build settings.
1ec5
added
documentation
1ec5
commented
Feb 25, 2020
| OUTPUT=$(OUTPUT) ./platform/macos/scripts/document.sh | ||
|
|
||
| .PHONY: genstrings | ||
| genstrings: |
There was a problem hiding this comment.
This make rule got removed along with all the other macOS rules at some point, but it’s actually important for keeping both the iOS and macOS map SDKs in sync with Transifex.
There was a problem hiding this comment.
cc @tmpsantos @mapbox/gl-native @brunoabinader
1ec5
commented
Feb 25, 2020
circle.yml
Outdated
| @@ -202,7 +202,7 @@ commands: | |||
| steps: | |||
| - run: | |||
| name: Install macOS dependencies | |||
| command: brew install cmake ccache | |||
| command: brew install cmake ccache pkg-config | |||
There was a problem hiding this comment.
1ec5
commented
Feb 25, 2020
| // AppKit incorrectly uses calibrated RGB when exporting HTML, so input | ||
| // calibrated RGB to ensure round-tripping. | ||
| // <rdar://problem/46115233> <http://www.openradar.me/46115233> | ||
| NSColor *redColor = [NSColor colorWithCalibratedRed:1 green:0 blue:0 alpha:1]; |
There was a problem hiding this comment.
This is a reprise of mapbox/mapbox-gl-native#13387 that’s now possible because CircleCI is running a newer version of macOS.
But not mbgl.
AppKit incorrectly uses calibrated RGB when exporting HTML, so input calibrated RGB to ensure round-tripping.
nishant-karajgikar
approved these changes
Feb 26, 2020
|
Thanks for doing this @1ec5 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the macOS map SDK that had previously been maintained in the Mapbox GL Native monorepo.
The macOS build has over a hundred warnings due to a CMake misconfiguration in gl-native, which will be fixed by mapbox/mapbox-gl-native#16228. That PR doesn’t strictly block this one, however.
This PR also cleans up the changelogs for both iOS and macOS. The overgrown “master” section of the macOS changelog has been reorganized and copyedited. The iOS changelog now reflects the iOS map SDK v5.5.1 release and incorporates some of the same copyediting as the macOS changelog.
Fixes mapbox/mapbox-gl-native#13386.
/cc @mapbox/maps-ios